Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DlibOptimizer -- don't hardcode solver_epsilon #1492

Open
dweindl opened this issue Oct 17, 2024 · 1 comment
Open

DlibOptimizer -- don't hardcode solver_epsilon #1492

dweindl opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels
optimization Related to optimization process

Comments

@dweindl
Copy link
Member

dweindl commented Oct 17, 2024

DlibOptimizer currently has a hardcoded solver_epsilon (the magic 0.002):

dlib.find_min_global(
get_fval_vararg,
list(lb),
list(ub),
int(self.options["maxiter"]),
0.002,
)

My current interpretation of that parameter (documentation is a bit sparse) is that it's the minimum absolute objective function improvement (https://github.com/davisking/dlib/blob/6d29e0c7d41dfdffb8c0a0f83995caae84df5083/dlib/global_optimization/global_function_search.cpp#L754). For that, this value is potentially rather high. I am not sure if we should override dlib's default at all (their default is 0), but at least it should be configurable by the user.

@dweindl dweindl added the optimization Related to optimization process label Oct 17, 2024
@PaulJonasJost PaulJonasJost self-assigned this Oct 18, 2024
@PaulJonasJost
Copy link
Collaborator

Agreed, will make it something the user can change but with default of 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Related to optimization process
Projects
None yet
Development

No branches or pull requests

2 participants