Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest build of abseil-cpp failed with elaborated-type-specifier for a scoped enum must not use the ‘class’ keyword #151

Closed
ja66 opened this issue Feb 22, 2024 · 3 comments · Fixed by #152
Labels
bug Something isn't working

Comments

@ja66
Copy link

ja66 commented Feb 22, 2024

Build fail
Build fail with elaborated-type-specifier for a scoped enum must not use the ‘class’ keyword in 3rd party code in
build/_deps/grpc-src/third_party/abseil-cpp/absl/strings/internal/str_format/extension.h:34

Reason is a missing include of #include <cstdint> before.

#include <cstdint>

#include "absl/base/config.h"
#include "absl/base/port.h"
#include "absl/meta/type_traits.h"
#include "absl/strings/internal/str_format/output.h"
#include "absl/strings/string_view.h"

namespace absl {
ABSL_NAMESPACE_BEGIN

enum class FormatConversionChar : uint8_t;
enum class FormatConversionCharSet : uint64_t;

I was able to complete the build (a few warnings though).
I wonder whether the include statement could be done outside of the fetched as a cmake statement.

@ja66 ja66 added the bug Something isn't working label Feb 22, 2024
@rainerschoe
Copy link
Member

Hi Jens, Thanks for reporting.
I will have a look, maybe we could simply step up the gRPC version of the dependency, as I am sure this problem would affect upstream code too.

@rainerschoe
Copy link
Member

reproduced with gcc (GCC) 13.2.1 20231011 (Red Hat 13.2.1-4)

@rainerschoe
Copy link
Member

I added PR #152 to step up gRPC version, which should fix this issue.

@ja66 : would you be willing to review this PR? (I somehow cannot request an official review from you, probably because you are not in the correct ORG)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants