Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The all-white background feels very harsh #37

Open
robredpath opened this issue Jan 10, 2025 · 6 comments
Open

The all-white background feels very harsh #37

robredpath opened this issue Jan 10, 2025 · 6 comments

Comments

@robredpath
Copy link
Contributor

robredpath commented Jan 10, 2025

When looking at a preview of d-portal that starts to make use of the design system, one piece of feedback from everyone reviewing was that the white background was problematic. Part of that is that some of the controls are white-on-white, which points to a need for some more designed elements/controls to be part of the design system. But, part of the feedback was that an all-white background just seemed too bright.

I have to admit I can't quite put my finger on why that's the case, because so many websites have a white background- including GitHub! But, somehow, it looks really bright. Introducing a light grey background made the white card elements "pop" far better and generally look nicer.

Any inputs/advice/reckons/etc welcome

@stevieflow
Copy link

From @notshi IATI/D-Portal#660

Used the light grey #F6F6F6 from the current IATI website - seems to fit! https://d-portal.org/ctrack.html?&flava=white#view=search

@robredpath robredpath changed the title Background colour other than white? The all-white background feels very harsh Jan 10, 2025
@robredpath
Copy link
Contributor Author

Nice - I'm pretty open to us using a light grey by default.

I looked into this a bit further and it turns out that the way most websites deal with it is to make the text a very dark grey rather than making the background not be white. That, alongside lots of thin borders and light-coloured interface elements seems to be enough to make an all-white background work.

@stevieflow
Copy link

Nice - I'm pretty open to us using a light grey by default.

Interested to know how we then do / roll that out (automagically !)

@robredpath
Copy link
Contributor Author

Interested to know how we then do / roll that out (automagically !)

I think we should see how it affects the other tools: what does the Validator look like with this, for example.

If we're then happy with the change, we just update the design system, publish a new version and roll it out tool-by-tool by bumping the version number.

@stevieflow
Copy link

Great thanks @robredpath

Sure - let's take a look!

@robredpath
Copy link
Contributor Author

I've asked Agile.coop to look into this as part of their current round of development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants