-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forest plot : Pulmonary - Cognitive track #167
Comments
added a script that replicates and studies the examples from https://cran.r-project.org/web/packages/forestplot/vignettes/forestplot.html Please refer to this script for re-study
The first draft of the forest plot graph has been stabilized. I have incorporated it into the report with dynamic table: in this way you can both view the summary, and explore the number. However, I am not pleased with the performance of However, to be frugal, I'd like to see if we can get away with this for now. I'll start building a more robust and flexible graphing machinery with ggplot (@wibeasley made a good start for me) at a slower pace, but in the meanwhile let's see if we can make it work. Please take a look at the report ( also available from Please leave your comment and suggestions in this thread. I'll try to implement them, but I may not be able to due to limitation of the NOTE: the average effect is caluculated using weights of sample size, basically following this recipe. Please let me know if this is incorrect, or you prefer a different method. A few specific questions:
|
@andkov - We should produce the I and R forest plots, although we may only present them in GitHub and not in the publication. It looks like you have differently sized points (squares), and the size differences are more manageable than the ones from Sean's plots, but they are not clearly associated with sample size differences, so I am uncertain what they mean. Can we invert TrailsB scores/values so that it reflects correct responses (like everything else) rather than errors? With respect to sorting: I realise (remember) now with your plots that in fact we have both different Cognitive AND different Pulmonary measures. Good to remind readers about the variability of both. I am happy with the sorting the way it is. I like how Sean's, with subgroupings rather than separate plots, is more compact, but I appreciate the flexibility that separate plots may afford (just seems like there are so many of them and it means so many more titles and headings!). Can you remind me why you use "process" rather than "variable"? Wednesday morning between 9 and 11:30 Pacific work for me. |
@andkov - also noticed that "Ravens" in MAP is labelled "Matrices". Can we please change it to Raven's so it will match LASA? Many thanks! I'll give a quick check for whether there are any other instances like this. ...actually, LASA is RavenColourAB and MAP is RavenStandard If this is too complicated, just label them both "raven", and we will include the other details in the Method section. |
Agenda:
|
Yes. We wanted a word to distinguish the role of a variable in the model (outcome vs predictor). However, outcome (at least in my understanding) is tied to the specific measure, as in However, this choice of words was selected to help us navigate the scripts easier. There is no reason why we cannot change the legend to reflect a more appropriate meaning. |
Good point. Here's what I've uncovered. According to this discussion the However, there is an option to make the sizes equal, so we can always resort to that if mapping the precision onto the box size in undesirable: |
rename Matrices into RavenStandard (MAP) and Raven into RabevColorAB (LASA)
done (commit: 01354aa) . For right now, I've kept the renaming to the script (as opposed to a csv, which we typically used for more robust and traceable renaming). |
I'm not sure what operation to perform to accomplish that. Do you mean taking the reciprocal of the point estimate for the slope and the residual? That should be very easy to do. But what about CI? Perhaps we can discuss this when we meet. |
@andkov - re TrailsB: sorry - wrong terminology - just need to reverse the sign. thanks! |
@andkov IJE Instructions: FIGURES • Figures should be submitted in editable image formats (such as jpg or tiff, not pdf). |
removed trailsb, changed table headings, restricted width of forest to -1 and 1
the adjustment we've discussed have been implemented. Please access the latest versions of report from the stable serving point for pulmonary track.
|
@andkov |
@andkov - forest plots look great! Can you adjust the spacing for Visualization? the forest plots themselves seem narrower than for the other domains. since the plot is the focus, we should give it as much space as possible. For publication, actually, I think the font of all headings etc should still be 12pt, so the other columns could all be narrower. Sad, I know - you prefer html - but for the png one we should just use standard (12pt, black) formatting. You can keep the fancy version for online viewing. |
TODO:
|
also added dynamic sizing of the graphs
@ampiccinin, I'm still working on pulling them together as a single image, as we discussed. The current solution distorts the images by stretching them to be of the same height, which is a deal breaker. I'm pretty confident I'll find a solution, but just FYI in worst case I can just pull them together in Photoshop. @wibeasley, any advice on how to concatenate multiple jpegs vertically while respecting their ratios? I"ve starting doing it here, but they come out distorted. To clarify, we need a single jpeg: putting them into an html table would have works otherwise, but alas. |
@andkov : forest plots are getting there! I have some picky and not-so-picky requests & queries -
|
@ampiccinin , The labeling and sorting, however, should be no problem. Let's see the scope of what re: 5. Do you mean the The graphs for each of the tracks are saved in corresponding folders:
Each file has a unique name in the form:
For example:
|
@andkov : Great!! Let's try to get by with forest plot::forest plot. The plots are purely a tool for communication (though of course that is the whole point of writing an article!) so we get as close as we can without driving ourselves crazy. Once reviews come back, if anyone comments on them (I sort of doubt the details that bug me will be what stands out to reviewers) we can deal with it then. |
into immediate and recognition. also corrected `delayed or working` into `delayed and working`
@ampiccinin , However, two things are hard to implement:
I've started it, but it needs a few values filled in. After that is done, we can sort by the type of response in memory tasks. |
Need to develop a graphing function to create forest plots from
catalog
type of data structures.Reading sources:
forestplot
package vignettemetafor
packageforest.plot.or
- stand-alone function from McGillSee documentation for
rmeta::forestplot
argumentsThe text was updated successfully, but these errors were encountered: