Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config_home_path from config file and HoardeConfig #348

Open
seivan opened this issue Jul 11, 2024 · 0 comments · May be fixed by #349
Open

Remove config_home_path from config file and HoardeConfig #348

seivan opened this issue Jul 11, 2024 · 0 comments · May be fixed by #349

Comments

@seivan
Copy link

seivan commented Jul 11, 2024

A config file shouldn't have a path to itself. It defeats the purpose.
If you don't have a config file, the env or default config path should be used for defining it.
If you do have a config file, then changing the value in the config would be undefined behaviour because the new config file might have a different config_home_path.

Most software that have a path to the config doesn't have it in the file itself, they it compute it, based on env or other stuff, like default.

There's a lot of paths in the code base were a config file is written and it gets an argument for the path, sometimes direct path and sometimes a base path. This depends on #347 where there is a get_hoard_config_path() function that will compute the path (but not create it).

Fix: #349
Depends on: #347

@seivan seivan linked a pull request Jul 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant