Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible enchant: Holding #54

Open
Tcll opened this issue Sep 5, 2017 · 2 comments
Open

Possible enchant: Holding #54

Tcll opened this issue Sep 5, 2017 · 2 comments

Comments

@Tcll
Copy link

Tcll commented Sep 5, 2017

this enchant is already available for specific mods such as Thermal Expansion. (none of which I use in my modpack)
the enchant is typically applied to select chests, bags, or other storage inventories to expand their storage capacity.

I'm not sure what mod provides the enchant, but it's not available in my modpack...
so I was thinking to change it a bit and possibly override the available enchant.

the changes:

  • more holding levels for even more space
  • apply to all storage inventories
  • apply to armor to expand the player inventory

if there's anything else you'd like to add, by all means, let your imagination/autism run free ;)

@DrZed
Copy link
Member

DrZed commented Sep 5, 2017

Player Inventory sounds difficult but worth trying maybe, it's worse with making it compatible with modded inventories to show player inventory in them as gui code has you manually add the player inventory every time.
Applicable to chests maybe the issue with that and balance issues are the following
- Making it store the enchant and save even when broken
- Making it not apply to the whole stack when applied by book in anvil
- Making double chests function as well
- Modifying the chest code can cause incompatibilities with other mods.
This is why it is for only the strongbox and satchel from thermal expansion and nothing more.

In the long run I may try to make it but probably won't happen because it'd break so much that everyone else relies on.

@Tcll
Copy link
Author

Tcll commented Sep 5, 2017

I had a feeling on some of that stuff.
of course it can always be disabled if issues arise.

I do currently have Infinite inventory, but if this gets added, I won't need it.
as for the other stuff, I personally don't have a mod that would be broken by modified chests.
but yeah, I understand ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants