Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

40023 XML review #249

Open
13 of 17 tasks
KerryHite opened this issue Jan 23, 2019 · 8 comments
Open
13 of 17 tasks

40023 XML review #249

KerryHite opened this issue Jan 23, 2019 · 8 comments

Comments

@KerryHite
Copy link
Contributor

KerryHite commented Jan 23, 2019

  • Passes FRUS TEI Schematron check
  • Passes RelaxNG schema check
  • Scripts run
  • Upload the FRUS TEI file into localhost
  • Upload page images to S3
  • Typography and characters
  • Source note coding
  • Table of contents
  • Tables, both participant and other
  • Openers and assorted segs
  • Datelines added and prepped for dates project
  • Postscripts and frus:attachments confirmed
  • Front matter
  • Back matter
  • Random sample
  • Volume metadata
  • eBook generation and review
@KerryHite
Copy link
Contributor Author

Note: all checks done in Oxygen without uploading to local host.
-d52, d234, and d305 fixed source notes (TNTs)
-all refs to frus1977-80v09 changed to frus1977-80Ed2v09 and Joe fixed bibliography to match volume
-all characters were checked and compared against PDF. All instances correct.

@KerryHite
Copy link
Contributor Author

KerryHite commented Jan 28, 2019

Three instances of &#. These were c&#175 where a footnote is noting marginalia in which the shorthand for "with" was used. Note: Verified html entity was correct.
68 hyphens were used in place of en dash in date ranges, etc.; 1 em dash that I corrected.
There are no page images
Persons and terms are bolded properly.

@joewiz
Copy link
Member

joewiz commented Jan 29, 2019

Hope this helps!

@mrgregan
Copy link
Contributor

mrgregan commented Feb 5, 2019

From @KerryHite: @joewiz, yes! It was to denote a line over the letter C. We'll do the page images once we ok the final XML.

@mrgregan
Copy link
Contributor

mrgregan commented Feb 5, 2019

Random sample: 18, 27, 33, 48, 55, 79, 111, 112, 139, 144, 154, 168, 200, 211, 273, 301, 324, 346. Issues with 27 (missing persons tag), 112 (ital and rom formatting switched)
Also, persons and terms missing see x-refs.

@KerryHite
Copy link
Contributor Author

Rechecked with new xml. Persons and terms are no longer missing see x-refs.

@KerryHite
Copy link
Contributor Author

Random sample: 12, 27, 32, 38, 52, 56, 60, 68, 80, 95, 112, 113, 120, 125, 148, 155, 174, 191, 274, 289, 312, 330
Results:
27. Missing Daoud persName (okay because there might be confusion with other Daoud); 32. Missing italics for content not declassified-I will fix; 52. Missing italics for content not declassified-I will fix; 112. Ital and Rom formatting switched-I will fix; 155. Missing italics for content not declassified-I will fix; 174 Missing italics for content not declassified-I will fix; 191. Missing italics for content not declassified-I will fix; 289. missing in signature 312. Missing italics for content not declassified-I will fix; 330. Missing in signature-I will fix
Consistent: Many instances of President Daoud not tagged in volume but this could be confusion with another Daoud. Did a general search and missing italics for content not declassified in many or all instances when located on the left margin of the dateline. Some missing codes.

@KerryHite
Copy link
Contributor Author

Added line breaks in signature blocks as needed throughout volume.
Fixed all instances: When is followed by (bracketed) information not declassified statement that statement needed to be italicized. This was 44 instances. Fixed ital/rom formatting in document 112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants