Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beware of min-width and min-height #18

Open
raphaelgoetter opened this issue Oct 31, 2016 · 4 comments
Open

Beware of min-width and min-height #18

raphaelgoetter opened this issue Oct 31, 2016 · 4 comments

Comments

@raphaelgoetter
Copy link

raphaelgoetter commented Oct 31, 2016

Hello,

You might consider adding some min-content fix on flex-items :

.fukol-grids > * {
  min-width: 0;
  min-height: 0;
}

Sources :

@Heydon
Copy link
Owner

Heydon commented Oct 31, 2016

Interesting! Do you have a test case?

@raphaelgoetter
Copy link
Author

The 2 links above contain test cases.

TLDR : all replaced elements (img, input, textarea, etc.) or long words like URL can break your flex-item without this "hack".

@Mottokrosh
Copy link

I actually ran into this just last week (not with Fukol, sorry, I used a "homebrew" version :P). Thanks for the links, I'm much happier knowing why that happened!

@cweekly
Copy link

cweekly commented Oct 6, 2020

Almost 5 years old but still interesting.
Looks like the min-width hack isn't necessary:
https://css-tricks.com/flexbox-truncated-text/#comment-1601483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants