Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backend 404 error showing up on console when creating a new pipeline. #134

Open
rupav opened this issue Jul 15, 2018 · 2 comments
Open
Assignees

Comments

@rupav
Copy link
Collaborator

rupav commented Jul 15, 2018

Expected Behaviour

If new pipe's name doesn't match with any existing, backend read api error should not be reflected back in the console.

Actual Behaviour

Currently, while creating a new pipeline, we check if pipeline with the same name if already present, if not we create it. But if there is no match, a error is caught for the read request to backend, which gets shown up as 404 error in the console.

Steps to Reproduce:

Create a new pipeline with a new name, and see your console.

@rupav rupav self-assigned this Jul 15, 2018
@majumderS
Copy link

majumderS commented Feb 26, 2019

Hi @rupav I have tried to work on this issue. I did two things to handle the situation here.

  1. from what I understood after going through the code, the main concern here is that "404" error response by the server is also popping up a corresponding browser console error.

  2. SO what I did instead is, instead of setting 404 error, I added a text "Filename doesnot exist" in data.py file. The status code hence gets automatically set to 200.

  3. next in bundle.min.js, under "success" checking, I also put a check for "Filename doesnot exist" check and then call the api.data.write route via dispatch action method.
    I am not sure if this should be the correct way but let me know what you think.

pic2
pic2

@rupav
Copy link
Collaborator Author

rupav commented Mar 10, 2019

Hi @majumderS
If you edit the bundle.min.js file, it would gets restored to original in the next build command, so that's not a solution, instead you need to add it in the source code.
"Filename doesnot exist" response can work, but why should we show this to the console/(user)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants