Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetFromName method in Cards should return multiple cards #15

Open
chucklu opened this issue Aug 30, 2019 · 0 comments
Open

GetFromName method in Cards should return multiple cards #15

chucklu opened this issue Aug 30, 2019 · 0 comments

Comments

@chucklu
Copy link

chucklu commented Aug 30, 2019

https://github.com/HearthSim/HearthDb/blob/master/HearthDb/Cards.cs#L40
Currently you are using FirstOrDefault to return only one card.

But now we have multiple cards with same card name but different card id.
"CardId": "ULD_291p"
"CardId": "ULD_291pe"
The above two cards have the same card name Heart of Vir'naal.

The same problem exists with card name Totemic Slam, four different cards with same name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chucklu