Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate non-deflate serialization #90

Open
jonhoo opened this issue May 29, 2020 · 2 comments
Open

Deprecate non-deflate serialization #90

jonhoo opened this issue May 29, 2020 · 2 comments

Comments

@jonhoo
Copy link
Collaborator

jonhoo commented May 29, 2020

As far as I can tell, the V2 log format in the Java implementation does not support not compressing the histograms. Should we remove support for that? Should we at least update the examples to prefer the more "standard" serializer that will interoperate with other hdrhistogram libraries?

cc @marshallpierce

@marshallpierce
Copy link
Collaborator

Yep, at the very least updating examples seems reasonable. Maybe people use uncompressed ones in practice? 🤔 Weird, but possible...

@jonhoo
Copy link
Collaborator Author

jonhoo commented May 30, 2020

I discovered today that the Python bindings don't even support uncompressed histograms. So was surprised by that for a bit when my histograms wouldn't parse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants