Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degraded performance and upload failure when projects reach >200 versions #1253

Closed
WiIIiam278 opened this issue Jul 24, 2023 · 3 comments
Closed
Labels
1. bug Something isn't working 2. backend This issue/pr relates to an issue/change on the backend needs testing

Comments

@WiIIiam278
Copy link

WiIIiam278 commented Jul 24, 2023

Observed/problematic behavior

I have a project on Hangar (https://hangar.papermc.io/William278/HuskHomes) with two channels; Alpha and Release.

I publish to the alpha channel continuously; every time a commit is made to my project, a version is published to Hangar via the API to this channel. This enables users to download bleeding edge versions if they so desire; only main releases are published to the release channel (in accordance with TOS)

I've now published about 200 versions to Hangar, and have noticed degraded performance as I continue to publish more; specifically:

  • Viewing the "versions" page on the site, I occasionally receive "request timed out after 4000ms" errors
  • I can no longer upload additional versions; I receive a 500 Internal Server Error through the API. I suspect this is because the underlying logic to fetch the list of versions is timing out

Expected behavior

Hangar gracefully handles me having more than 200 versions on a project, lets me continue to upload new versions, and smoothly browse existing ones

Steps to reproduce

Have a project with over 200 versions, and attempt to upload another version, either through the API or the frontend.

You can also experience the timeout issue by going to https://hangar.papermc.io/William278/HuskHomes/versions and observing the errors in the bottom-right

Other

No response

@kennytv kennytv added 1. bug Something isn't working 2. backend This issue/pr relates to an issue/change on the backend labels Aug 11, 2023
@kennytv
Copy link
Member

kennytv commented Aug 13, 2023

Opening the versions page doesn't seem to be slow (although it's not a paginator so lol). Just to clarify, when uploading via the website, did this happen when clicking 'create' in the final step, or before that?

@WiIIiam278
Copy link
Author

WiIIiam278 commented Aug 26, 2023

Opening the versions page doesn't seem to be slow (although it's not a paginator so lol). Just to clarify, when uploading via the website, did this happen when clicking 'create' in the final step, or before that?

Sorry for the slow reply!

This occured both when hitting "Create" in the final page and when doing an upload via the API: https://github.com/WiIIiam278/mc-publish/tree/hangar

I haven't tested since the changes rolled out today :) I noticed it now paginates, which is neat.

@kennytv
Copy link
Member

kennytv commented May 4, 2024

This should be resolved with 98733f6

@kennytv kennytv closed this as completed May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. bug Something isn't working 2. backend This issue/pr relates to an issue/change on the backend needs testing
Projects
Status: Done
Development

No branches or pull requests

2 participants