Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add "also check subfolders" checkbox to the folder list of Autofiler #13

Open
Giova84 opened this issue May 22, 2016 · 7 comments

Comments

@Giova84
Copy link

Giova84 commented May 22, 2016

I have added a folder to monitor, under the option "automatically run autofiler on the contents of these folder", but AutoFiler will only monitor the root of these folders.

Eg: I added /boot/home/Downloads but would be nice have Autofiler also watch for subfolders of /boot/home/Downloads (eg /boot/home/Downloads/foo1, /boot/home/Downloads/foo2 and so on).

I was thinking to implement this feature by adding a checkbox called "also check subfolders" in the "AutoFiler" tab.

@humdingerb
Copy link
Member

It's not completely trivial, because a NodeMonitor watches single nodes (files/folders). No easy way to have it traverse down its subfolders. I'm looking into it and may have found the way to do it...
It'd be even better to have this setting not gobally, but per watched folder. That's even more complicated, though, and will take me even longer to implement. :)

@Giova84
Copy link
Author

Giova84 commented May 23, 2016

« It'd be even better to have this setting not gobally, but per watched folder.»

That's would be definitely better :-)
Many thanks for all your efforts, Humdinger!

@owenca
Copy link
Contributor

owenca commented Apr 9, 2017

The checkbox will be a new column in the folders list window, which must be changed to use ColumnListView, right? Ideally, this change should be made after Filer is migrated to using layout management. The non-GUI part will be easier for me. So should we wait?

@humdingerb
Copy link
Member

The only parts of Filer still in need of layout management is the window for adding/editing rules. The AutoFiler tab already uses it.
Using a ColumnListView is a good idea in general. Unfortunately, it doesn't suport including checkboxes. So the empty checkbox and activated checkbox has to be drawn manually either with custom icons (harder) or using UTF8 symbols (easy).

Question is, how to toggle it. A double-click works, but isn't obvious, so should only be implemented in addition at most.
Short of another button, and nicer anyway, is to monitor clicks in the "Subfolders" column of an entry.

@owenca
Copy link
Contributor

owenca commented Apr 10, 2017

Can we do it without ColumnListView? Would that still support layout management? It would be nice if a column of checkboxes can be used.

@humdingerb
Copy link
Member

I don't see how we can get away without a ColumnListView. How would a user know what the checkmark is for if there wasn't a column header like "Subfolders"?
WRT to checkboxes, as I said, no BCheckboxes directly. Needs either drawing our own, or using UTF8.

@owenca
Copy link
Contributor

owenca commented Apr 15, 2017

Ok. I will first convert it to using ColumnListView without adding the new column when I am ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants