Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toggle to disable the injecting services feature #2397

Open
pkly opened this issue Sep 4, 2024 · 2 comments
Open

Add a toggle to disable the injecting services feature #2397

pkly opened this issue Sep 4, 2024 · 2 comments

Comments

@pkly
Copy link

pkly commented Sep 4, 2024

It's bad for me as I know what I want to write and I have 5 suggestions that I don't need. It keeps adding services to my classes and it's annoying. I can't find a way to disable it atm, is there one?

@kAlvaro
Copy link

kAlvaro commented Jan 13, 2025

When I use auto-completion for $this->, the plug-in is adding non-existing class properties with top priority and, should I pick one, it changes or creates the class constructor to inject a new service. IMHO, this is wrong for several reasons:

  • It can break my app by introducing circular dependencies.
  • I don't want the IDE to make design decisions for me, let alone without telling me.
  • 99% of the times I type $this-> what I want is to use existing class properties, not add new ones.
  • When you want to add new properties, the intuitive way is to add a new property directly to either the class or the constructor. Doing it from the location where you want to use and as part of auto-completion is a bit convoluted.

Is there a way to disable this?

image

@pkly
Copy link
Author

pkly commented Jan 13, 2025

yeah it's annoying and barely works, doesn't respect formatting styles and is overall not a good thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants