Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new languages #1

Open
4 tasks
tonysurma opened this issue Jun 21, 2018 · 6 comments
Open
4 tasks

Add support for new languages #1

tonysurma opened this issue Jun 21, 2018 · 6 comments

Comments

@tonysurma
Copy link
Member

tonysurma commented Jun 21, 2018 •
edited
Loading

(originally created by @toolboc & @KSLHacks)

EmergencyServicesBot currently supports the top 3 spoken languages worldwide (Chinese, English, and Spanish). We would like to expand our impact to more individuals by adding more language support for example Arabic (the 4th most spoken language).

To begin, you will need to familiarize with how the current languages are utilized in the codebase. We key off of available languages in 5 distinct areas:

  1. The Resources folder, which drives client-side menu translations. Naming is important and will need to conform to the naming convention (i.e. for Arabic you would use Resources.ar-SA.resx for more examples see: www.csharp-examples.net/culture-names/) and supply valid translations similar to the existing .resx files.

  2. In RootDialog.cs and SetLanguage.cs you will need to initialize a new cultureInfo (for example, for Arabic use "ar-SA").

  3. Modify the logic in SetLanguage.cs for StartAsync and onLanguageSelect to use the new language.

  4. Modify the logic in RootDialog.cs for DetectAndSaveUserLanguageAsync to use the new Language

  5. Add support for the new language in RootDialog.cs for SendWelcomeMessage to support the new language

Language Support:
This was referenced Jun 21, 2018
Open
Open
Closed
Open
@a-elnajjar
Copy link

Hi @tonysurma I can help with Arabic :)

@toolboc
Copy link
Collaborator

toolboc commented Jul 24, 2018

@a-elnajjar , we could definitely use Arabic support if you can help out. Feel free to create a new issue to file a PR against. I would be happy to help if you have any questions.

@a-elnajjar
Copy link

@toolboc I have created a new issue and start adding logic to use the Arabic translation. I have one
question is Quickstart guide is out of date because Microsoft changes a couple of stuff?

@pada57
Copy link

pada57 commented Nov 1, 2018

Hello, i can help with french

@toolboc
Copy link
Collaborator

toolboc commented Nov 1, 2018

@a-elnajjar , which areas of the Quickstart are you having issues with?

@toolboc
Copy link
Collaborator

toolboc commented Nov 1, 2018

@pada57 , we would be happy to accept a PR if you area able to assist with French translation.

This was referenced Feb 10, 2019
Open
Closed
Merged
toolboc pushed a commit that referenced this issue Feb 12, 2019
@pada57 @toolboc
Add support for new languages: French #1 #5 (#15)
c73c796 
* Update Microsoft.Net.Compilers

* Refactor rootdialog to use common constants and one method to get CI

* Add french culture and refactor constants

* Refactor setLanguage and  add french

* Change assembly name

* Added french resource

* Change french display name

* Add french welcome message and choices

* Set language to french

* Revert to use Authorization header for QnA client

* Add null operator in case null response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@a-elnajjar @toolboc @tonysurma @pada57