Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into inline vs submit validation on login/signup #116

Open
avye opened this issue Jun 28, 2016 · 3 comments
Open

Look into inline vs submit validation on login/signup #116

avye opened this issue Jun 28, 2016 · 3 comments
Assignees

Comments

@avye
Copy link
Collaborator

avye commented Jun 28, 2016

-Username and password validation checks should only be done upon login press

@echo304
Copy link
Contributor

echo304 commented Jun 29, 2016

When user succeed to login, user data isn't store in state.auth.user

@brentcolson
Copy link
Collaborator

^^ due to server not return user obj, will update server and save to redux store

@brentcolson
Copy link
Collaborator

@avye what did yo mean by "username and password validation checks should only be done upon login press"? Do you mean not showing an error like an invalid email address until they hit "login" or "signup"? Just want to make sure I know what you mean...

@brentcolson brentcolson removed the ready label Jun 30, 2016
@brentcolson brentcolson changed the title Fix login bugs Look into inline vs submit validation on login/signup Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants