From 8cace195d58c351c91bcdf64ba0a85adb4687542 Mon Sep 17 00:00:00 2001 From: "Rafiqi, Abdullah" Date: Wed, 2 Aug 2023 22:21:33 -0400 Subject: [PATCH 1/4] QA fix - profile valueset url updated (coverage,medicationdispense,medicationdispensedeclined,medicationstatement) --- .../profiles/StructureDefinition-qicore-medicationdispense.json | 2 +- .../StructureDefinition-qicore-medicationdispensedeclilned.json | 2 +- .../StructureDefinition-qicore-medicationstatement.json | 2 +- input/profiles/Structuredefinition-qicore-coverage.json | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/input/profiles/StructureDefinition-qicore-medicationdispense.json b/input/profiles/StructureDefinition-qicore-medicationdispense.json index 398ade15..c623fab9 100644 --- a/input/profiles/StructureDefinition-qicore-medicationdispense.json +++ b/input/profiles/StructureDefinition-qicore-medicationdispense.json @@ -98,7 +98,7 @@ "binding" : { "strength" : "extensible", "description" : "The set of RxNorm codes to represent medications", - "valueSet" : "https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4" + "valueSet" : "http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1010.4" } }, { diff --git a/input/profiles/StructureDefinition-qicore-medicationdispensedeclilned.json b/input/profiles/StructureDefinition-qicore-medicationdispensedeclilned.json index b64fda54..c1f13532 100644 --- a/input/profiles/StructureDefinition-qicore-medicationdispensedeclilned.json +++ b/input/profiles/StructureDefinition-qicore-medicationdispensedeclilned.json @@ -134,7 +134,7 @@ "binding" : { "strength" : "extensible", "description" : "The set of RxNorm codes to represent medications", - "valueSet" : "https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4" + "valueSet" : "http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1010.4" } }, { diff --git a/input/profiles/StructureDefinition-qicore-medicationstatement.json b/input/profiles/StructureDefinition-qicore-medicationstatement.json index d9c1bb92..94179e11 100644 --- a/input/profiles/StructureDefinition-qicore-medicationstatement.json +++ b/input/profiles/StructureDefinition-qicore-medicationstatement.json @@ -74,7 +74,7 @@ "binding" : { "strength" : "preferred", "description" : "The set of RxNorm codes to represent medications", - "valueSet" : "https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4" + "valueSet" : "http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1010.4" } }, { diff --git a/input/profiles/Structuredefinition-qicore-coverage.json b/input/profiles/Structuredefinition-qicore-coverage.json index 4509304b..d3b9f9af 100644 --- a/input/profiles/Structuredefinition-qicore-coverage.json +++ b/input/profiles/Structuredefinition-qicore-coverage.json @@ -78,7 +78,7 @@ "binding" : { "strength" : "extensible", "description" : "Categories of types of health care payor entities as defined by the US Public Health Data Consortium SOP code system", - "valueSet" : "https://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.114222.4.11.3591" + "valueSet" : "http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.114222.4.11.3591" } }, { From 1dba9e5ead07824bd0213e9c1846e936a891bf97 Mon Sep 17 00:00:00 2001 From: "Rafiqi, Abdullah" Date: Wed, 2 Aug 2023 22:22:04 -0400 Subject: [PATCH 2/4] QA fix - ignoreWarnings updated --- input/ignoreWarnings.txt | 37 +++++++++++++------------------------ 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/input/ignoreWarnings.txt b/input/ignoreWarnings.txt index 11a87403..ae3d9d75 100644 --- a/input/ignoreWarnings.txt +++ b/input/ignoreWarnings.txt @@ -3,41 +3,30 @@ # The following issue is related to the publisher and discussed in the following zulip chat (https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/'could.20not.20reference'.20error.20with.20modifier.20extension) ERROR: ?pkp-1?: The reference http://hl7.org/fhir/5.0/StructureDefinition/extension-DeviceRequest.doNotPerform could not be resolved -# Issue within the ImagingStudy snapshot and brought to attention in the following thread: https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/ValueSet.20not.20found.20by.20validator.20or.20cannot.20be.20checked -ValueSet http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_29.html not found -WARNING: StructureDefinition/qicore-imagingstudy: StructureDefinition.snapshot.element[11].binding: The valueSet reference http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_29.html on element ImagingStudy.modality could not be resolved -WARNING: StructureDefinition/qicore-imagingstudy: StructureDefinition.snapshot.element[22].binding: The valueSet reference http://www.rsna.org/RadLex_Playbook.aspx on element ImagingStudy.procedureCode could not be resolved -WARNING: StructureDefinition/qicore-imagingstudy: StructureDefinition.snapshot.element[34].binding: The valueSet reference http://dicom.nema.org/medical/dicom/current/output/chtml/part16/sect_CID_29.html on element ImagingStudy.series.modality could not be resolved -WARNING: StructureDefinition/qicore-imagingstudy: StructureDefinition.snapshot.element[53].binding: The valueSet reference http://dicom.nema.org/medical/dicom/current/output/chtml/part04/sect_B.5.html#table_B.5-1 on element ImagingStudy.series.instance.sopClass could not be resolved - # Profiles not based on US Core and variance requests have been approved: https://jira.hl7.org/browse/FHIR-34125 WARNING: StructureDefinition.where(url = 'http://hl7.org/fhir/us/qicore/StructureDefinition/qicore-device').baseDefinition: US FHIR Usage rules require that all profiles on Device derive from the core US profile WARNING: StructureDefinition.where(url = 'http://hl7.org/fhir/us/qicore/StructureDefinition/qicore-observationcancelled').baseDefinition: US FHIR Usage rules require that all profiles on Observation derive from one of the base US profiles -# VSAC dependency updated but the following issues are still known and is a valid valueset,code systems and codes within -The valueSet reference https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4 on element MedicationDispense.medication[x] could not be resolved -The valueSet reference https://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.114222.4.11.3591 on element Coverage.type could not be resolved -ValueSet https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4 not found -ValueSet https://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.114222.4.11.3591 not found -WARNING: StructureDefinition/qicore-coverage: StructureDefinition.differential.element[1].binding: The valueSet reference https://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.114222.4.11.3591 on element Coverage.type could not be resolved -WARNING: StructureDefinition/qicore-medicationdispense: StructureDefinition.snapshot.element[14].binding: The valueSet reference https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4 on element MedicationDispense.medication[x] could not be resolved -WARNING: StructureDefinition/qicore-medicationstatement: StructureDefinition.differential.element[2].binding: The valueSet reference https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4 on element MedicationStatement.medication[x] could not be resolved -WARNING: StructureDefinition/qicore-medicationstatement: StructureDefinition.snapshot.element[15].binding: The valueSet reference https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1010.4 on element MedicationStatement.medication[x] could not be resolved - # The following warnings in the examples are being generated due to no code within the codeable concept but referencing a valueset instead, consistent with the negation pattern -No code provided, and a code should be provided from the value set 'US Core Procedure Codes' (http://hl7.org/fhir/us/core/ValueSet/us-core-procedure-code|6.1.0-snapshot1) -No code provided, and a code should be provided from the value set 'CVX Vaccines Administered Vaccine Set' (http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1010.6|20220701) +WARNING: Immunization/negation-example: Immunization.vaccineCode: No code provided, and a code should be provided from the value set 'CVX Vaccines Administered Vaccine Set' (http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1010.6|20220701) +WARNING: MedicationDispense/negation-example: MedicationDispense.medication.ofType(CodeableConcept): No code provided, and a code should be provided from the value set 'Medication Clinical Drug' (http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1010.4|20170601) +WARNING: Procedure/negation-example: Procedure.code: No code provided, and a code should be provided from the value set 'US Core Procedure Codes' (http://hl7.org/fhir/us/core/ValueSet/us-core-procedure-code|6.1.0-snapshot1) +WARNING: ServiceRequest/negation-example: ServiceRequest.code: No code provided, and a code should be provided from the value set 'US Core Procedure Codes' (http://hl7.org/fhir/us/core/ValueSet/us-core-procedure-code|6.1.0-snapshot1) -# The following information messages are being generated in the examples using valid codes in codesystems but validator cannot confirm + +# The following examples are using valid codes in the CPT/SOPT codesystems but THO doesn't define the codes. The definition for the Code System with URI 'http://www.ama-assn.org/go/cpt' doesnt provide any codes so the code cannot be validated -Unable to check whether the code is in the value set http://hl7.org/fhir/us/core/ValueSet/us-core-encounter-type|6.1.0 The definition for the Code System with URI 'https://nahdo.org/sopt' doesnt provide any codes so the code cannot be validated -No code provided, and a code should be provided from the value set 'US Core Procedure Codes' (http://hl7.org/fhir/us/core/ValueSet/us-core-procedure-code|6.1.0) +WARNING: Encounter/encounter-ed-example: Encounter.type[0]: Unable to check whether the code is in the value set http://hl7.org/fhir/us/core/ValueSet/us-core-encounter-type|6.1.0-snapshot1 +WARNING: Encounter/example: Encounter.type[0]: Unable to check whether the code is in the value set http://hl7.org/fhir/us/core/ValueSet/us-core-encounter-type|6.1.0-snapshot1 -# Confirmed these slices in the following examples align/match with the profile(s) referenced -This element does not match any known slice defined in the profile http://hl7.org/fhir/us/qicore/StructureDefinition/qicore-simple-observation|6.0.0-ballot +# The slices in the examples are present in the SimpleObservation.value[x] profile element as valueQuantity +INFORMATION: Observation/example: Observation.value.ofType(Quantity): This element does not match any known slice defined in the profile http://hl7.org/fhir/us/qicore/StructureDefinition/qicore-simple-observation|6.0.0-ballot +INFORMATION: Observation/example-gestation: Observation.value.ofType(Quantity): This element does not match any known slice defined in the profile http://hl7.org/fhir/us/qicore/StructureDefinition/qicore-simple-observation|6.0.0-ballot # The following messages are being generated from the inherited/base resource snapshot +WARNING: StructureDefinition/qicore-imagingstudy: StructureDefinition.snapshot.element[22].binding: The valueSet reference http://www.rsna.org/RadLex_Playbook.aspx on element ImagingStudy.procedureCode could not be resolved +WARNING: StructureDefinition/qicore-imagingstudy: StructureDefinition.snapshot.element[53].binding: The valueSet reference http://dicom.nema.org/medical/dicom/current/output/chtml/part04/sect_B.5.html#table_B.5-1 on element ImagingStudy.series.instance.sopClass could not be resolved WARNING: StructureDefinition/qicore-allergyintolerance: StructureDefinition.snapshot.element[0].constraint[7]: 1: The left side is inherently a collection, and so the expression 'verificationStatus.coding.code = 'refuted'' may fail or return false if there is more than one item in the content being evaluated WARNING: StructureDefinition/qicore-careplan: StructureDefinition.snapshot.element[9].comment: The markdown contains content that appears to be an embedded HTML tag starting at 'Th'. This will (or SHOULD) be escaped by the presentation layer. The content should be checked to confirm that this is the desired behaviour INFORMATION: StructureDefinition/qicore-medicationdispense: StructureDefinition.snapshot.element[28].mapping[0].map: The string value contains text that looks like embedded HTML tags. If this content is rendered to HTML without appropriate post-processing, it may be a security risk From 20a7bb3e54c6bd0089d4ef80887ddf48d1dc890d Mon Sep 17 00:00:00 2001 From: "Rafiqi, Abdullah" Date: Wed, 2 Aug 2023 22:22:45 -0400 Subject: [PATCH 3/4] QA fix - dicom dependency added --- input/qicore.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/input/qicore.xml b/input/qicore.xml index 021f7cdc..e0386f64 100644 --- a/input/qicore.xml +++ b/input/qicore.xml @@ -31,6 +31,11 @@ + + + + + From 9154789bf74217f95191c236b50855cb76db07ec Mon Sep 17 00:00:00 2001 From: "Rafiqi, Abdullah" Date: Wed, 2 Aug 2023 22:23:47 -0400 Subject: [PATCH 4/4] QA fix - publication request "mode" updated to 'working' --- publication-request.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/publication-request.json b/publication-request.json index 8d687f86..37ab9c32 100644 --- a/publication-request.json +++ b/publication-request.json @@ -2,7 +2,7 @@ "package-id" : "hl7.fhir.us.qicore", "version" : "6.0.0-ballot", "path" : "http://hl7.org/fhir/us/qicore/2023Sep", - "mode": "milestone", + "mode": "working", "status" : "ballot", "sequence" : "STU6 (v6.0.0)", "desc" : "Release 6.0.0-ballot STU6 Ballot",