Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in the job_classification.conf if there's a misconfigured site_bucket_criteria_expr you don't find it until runtime #400

Open
StevenCTimm opened this issue Jan 18, 2022 · 0 comments

Comments

@StevenCTimm
Copy link
Contributor

If there is a malformed site_bucket_criteria_expr
(jsonnet is well formed but the stuff within the double quotes is not good pandas)

then you won't find out until the glidein_requests transform tries to execute it and errors out with a run time error.

Need some way to know if we have good Pandas query language in the config file.

Can't necessarily determine that all the variables we are querying on, exist, but should be able
to check if it's syntactically correct.

The incident in question had an extra single quote at the front of the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant