Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources should go offline if the client channel offline #638

Closed
knoepfel opened this issue Apr 5, 2022 · 2 comments
Closed

Sources should go offline if the client channel offline #638

knoepfel opened this issue Apr 5, 2022 · 2 comments
Labels
fixed_in_rc

Comments

@knoepfel
Copy link
Contributor

knoepfel commented Apr 5, 2022 •
edited
Loading

With DE 2.0, a channel will go offline if one of the sources it depends upon sends a shutdown flag. However, there is no feedback mechanism to shut down the other sources the offline channel may have used. This will cause online sources to continue publishing messages to the Redis queues with nothing to consume them.
@StevenCTimm
Copy link

StevenCTimm commented Apr 5, 2022 •
edited by knoepfel
Loading

see HEPCloud/decisionengine_modules#410 for what caused the source in question to go offline.

@knoepfel knoepfel changed the title Channel should go into IDLE state if one of its required sources goes offline Sources should go offline if the client channel offline Apr 8, 2022
@knoepfel knoepfel mentioned this issue Apr 8, 2022
Open
@StevenCTimm
Copy link

believe this now addressed with recent PR's from Kyle. once those are merged into master we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed_in_rc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mambelli @knoepfel @StevenCTimm