Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with x_t (noise) prediction and some question about the training loss. #232

Open
kaipengfang opened this issue Dec 11, 2024 · 2 comments

Comments

@kaipengfang
Copy link

kaipengfang commented Dec 11, 2024

  1. Based on Issues Loss weights used during training #19 and the config, Geometric losses are not used. Instead, they are implemented through the 263-dimensional motion representation. Therefore, geometric losses will never be used; they are just redundant code. Is my understanding correct?
  2. Why use x_0 as the training target? Is there an explanation for this? Currently, most mainstream diffusion models predict xt instead.
  3. When I set the code to predict x_t as the training target, I found that the final results were very poor (
    Training for 23,000 steps, use linear beta scheduler, the character keeps shaking and doesn't perform the action well). What could be the reason for this? I only made the change to set self.model_mean_type = ModelMeanType.EPSILON in the training and sampling code. Could such a simple modification cause any issues?

predict x_t sample results:

sample01.mp4
sample02.mp4
@GuyTevet
Copy link
Owner

Try to also change the noise scheduling to linear instead of cosine.

@kaipengfang
Copy link
Author

kaipengfang commented Jan 30, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants