Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluggableSet missing methods #13

Open
JupiterJones opened this issue Nov 12, 2021 · 2 comments
Open

PluggableSet missing methods #13

JupiterJones opened this issue Nov 12, 2021 · 2 comments

Comments

@JupiterJones
Copy link
Contributor

(#( 1 2 3 4 ) groupedBy: [ :i | i even ]) keys

This throws a DNU since PluggableSet has no accessors for hashBlock (or equalsBlock).

@dalehenrich
Copy link
Member

PluggableSet inherits from Set which inherits from UnorderedCollection ... and I suspect that all UnorderedCollections will fail ... in fact it might be that only Array works properly?

@dassi
Copy link

dassi commented Jan 25, 2022

Stumbled across the same issue. PluggableSet has no methods at all, this is rather suspicious anyway. I guess this has been forgotten when porting from Squeak's code (since it is in the Squeak package)?

The single user of PluggableSet is the method PluggableDictionary>>keys. Like in @JupiterJones example, this only yields to a DNU if you do groupedBy: followed by keys.

My temporary workaround sledgehammer solution, redefine the method, not using PluggableSet at all:

PluggableDictionary>>keys
  ^ super keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants