-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScrollThumb is loading the wrong skin #109
Comments
The ScrollThumb inherrits Button. Buttons can have 3 different states (up/down/hover), so why not have those states for the ScrollThumb, too? The themes from feathers provide different images for vertical and horizontal, so it makes sense to have both, with the 3 button states this leads to 6 states in total. |
Oh, another alternative would be to have HorizontalScrollThumb and VerticalScrollThumb as different Components, but I am not so sure about that... |
Yes, I agree that the ScrollThumb should have the same button states. But why is the redraw function looking for a skin named horizontal_thumb or vertical_thumb? |
I think you are right... I think this as a bug. |
The ScrollThumb has 6 thumb states:
'horizontal_up', 'vertical_up', 'horizontal_down', 'vertical_down', 'horizontal_hover', 'vertical_hover',
but in the redraw function it is trying to load a skin named 'horizontal_thumb' or 'vertical_thumb'
which is not present.
Is there a reason why the skin names and states are different?
Shouldn't the ScrollThumb have a hover and down skin like a normal button?
The text was updated successfully, but these errors were encountered: