Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Remove Font-Awesome from compiled css #1648

Closed
gimzani opened this issue Dec 11, 2018 · 2 comments
Closed

[FEATURE REQUEST] Remove Font-Awesome from compiled css #1648

gimzani opened this issue Dec 11, 2018 · 2 comments
Labels

Comments

@gimzani
Copy link

gimzani commented Dec 11, 2018

Hello - quick suggestion:

I'd suggest removing font-awesome from the minified css file.

The reason for this is that many developers are using node - and there is a conflict with loading the font files where it says "OTS parsing error: invalid version tag".

If instead you declare that grapes requires a separate install of font-awesome you get several benefits:

  • No conflicts using node
  • The developer can decide which version of font-awesome they want to use.
  • The developer can store the css wherever they like

Just a thought.

Cheers!

@artf
Copy link
Member

artf commented Dec 11, 2018

Thanks for the request, Benjamin. Actually, we have already an open issue about this argument here, so I close this one

@artf artf closed this as completed Dec 11, 2018
@lock
Copy link

lock bot commented Dec 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Dec 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants