Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing webpack/declaration build does not cause cli process to exit with non-zero code #291

Open
joeldentici opened this issue Feb 23, 2024 · 0 comments

Comments

@joeldentici
Copy link

We noticed when the webpack build fails or the typescript declaration emitting step fails, the cli process does not exit with a non-zero code. This is problematic in a CI context as the CI pipeline will continue running the next steps in the job/next job as it doesn't detect the failure.

The following updates should probably be made:

  • Catch errors thrown by buildDeclaration
  • If an error is caught by buildDeclaration or the errors variable has a truthy value, add code to call process.exit with a non-zero code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant