Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whereami: add support for secure gRPC port using ENV variables #471

Open
gbrayut opened this issue Jan 25, 2023 · 1 comment
Open

whereami: add support for secure gRPC port using ENV variables #471

gbrayut opened this issue Jan 25, 2023 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gbrayut
Copy link
Member

gbrayut commented Jan 25, 2023

Whereami currently supports gRPC with grpc.health.v1.Health checks but only using insecure non-tls port.

Google Cloud Load Balancers require end-to-end encryption so it can use ALPN to upgrade backend connections to HTTP/2. It would be useful if whereami could support secure port gRPC instead of insecure using environment variables that indicate which certificate and key should be used by the gRPC server. We can then use cert-manager or SPIFFE+CSI to inject the certificates into the pod.

I discussed this briefly with @theemadnes and he requested this issue be assigned to him.

@theemadnes theemadnes self-assigned this Jan 25, 2023
@theemadnes
Copy link
Member

thanks @gbrayut

@charlieyu1996 charlieyu1996 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 27, 2023
@bourgeoisor bourgeoisor added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants