Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor integration tests #84

Open
dzelemba opened this issue Jun 19, 2020 · 0 comments
Open

Refactor integration tests #84

dzelemba opened this issue Jun 19, 2020 · 0 comments

Comments

@dzelemba
Copy link
Contributor

Filling this as a future cleanup.

Integration tests are currently using a combination of bash scripts & cloud build settings to run a host of tests all part of one global config. This causes a few issues:

  • it's hard to isolate individual test cases to understand what is being covered
  • changing one test case can break other independent tests (e.g. having to update the build step names, or inserting into the one shared dicomstore)
  • cleanup is easy to miss
  • diff checks are just based on file comparisons which makes them hard to debug

Instead we can move towards using a proper language to write the tests (like Java or Python) that provides connivence methods for creating/cleaning up test environments. A design doc outlining this would be a good next step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant