-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git Commit Sha in Container Image Tag #156
Comments
This should be an easy thing to fix, but then, it complicates the command we print out a little bit. Should be as easy as exec'ing into
Feel free to implement if you'd like. |
Would we have to also do a push for |
Not if we use it? |
Sorry, I'm not very familiar with how this all works. If we want to tag an image with the short sha and make it so users can pull the |
Yeah, but I'm not exactly sure users pulling images after deploying is a common journey. We'd tag the image twice and push twice (one of them would be a soft-push just creating the tag). Given we have tools like pack & Jib involved, we might not be able to tag multiple times as efficiently as docker. |
There are times where I pull the image for local testing and having |
If someone wants to pull images I'm not sure why they can't pull with the :tag ? |
They definitely can, it's just a bit more cumbersome. |
It'd be cool to put the git commit sha in the container image tag.
The text was updated successfully, but these errors were encountered: