Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy support? #597

Open
3 tasks done
sobolevn opened this issue Jan 20, 2025 · 1 comment
Open
3 tasks done

Mypy support? #597

sobolevn opened this issue Jan 20, 2025 · 1 comment
Labels
question Further information is requested

Comments

@sobolevn
Copy link
Contributor

Summary

Hi! I am working on mypy and noticed that your project has Found 973 errors in 86 files (checked 134 source files) when checked with mypy

Reproduction Steps

  1. poetry install --with=dev
  2. mypy steam

Expected Results

I expect to see no errors, since mypy is a dev dependency of this project and it also has a configurations.

But, on the other hand it is not executed in the CI.
So, what is the current status of mypy in this project?

Actual Results

Found 973 errors in 86 files (checked 134 source files)

I am not going to paste all of them, because this is going to be a wall of text.

System Information

main branch

Checklist

  • I have searched the issues for duplicates.
  • I have shown the entire traceback, if possible.
  • I have removed my username, password, shared/identity secrets and refresh/access tokens from display, if visible.
@Gobot1234
Copy link
Owner

I currently use pyright as it's the checker built into vsc, and haven't touched mypy in quite a while.

I haven't been keeping up that well with the type checking in the ext.commands library but everything else should be type checkable.

Feel free to remove from mypy primer but I think it still has a fair few issues that caused regressions in pyright so might be useful.

@Gobot1234 Gobot1234 added question Further information is requested and removed bug Something isn't working labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants