Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI is missing peer dependencies #8

Open
Soreine opened this issue Jan 3, 2018 · 1 comment
Open

CLI is missing peer dependencies #8

Soreine opened this issue Jan 3, 2018 · 1 comment
Labels
bug

Comments

@Soreine
Copy link
Contributor

Soreine commented Jan 3, 2018

slate, immutable etc. are peer dependencies, and are not installed when doing npm i -g slate-hyperprint
@Soreine Soreine added the bug label Jan 3, 2018
@Soreine Soreine changed the title CLI is missing global dependency CLI is missing peer dependencies Jan 3, 2018
@zhouzi
Copy link
Contributor

zhouzi commented Mar 26, 2018 •
edited
Loading

I'd suggest two possible solutions:

  1. Publish slate-hyperprint-cli as a separate package with a dependency on slate-hyperpint and its peer dependencies.
  2. Advise users to install the global CLI through install-peerdeps, e.g install-peerdeps slate-hyperprint -g (I didn't give that a try, I believe it'd work).

EDIT: I just noticed that the CLI's peer dependencies are not declared, which makes sense as the CLI's dependencies are different from slate-hyperprint's main purpose. A separate package would probably be the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhouzi @Soreine