Skip to content
This repository has been archived by the owner on Dec 5, 2021. It is now read-only.

[Feature] QuickShop PAPI Placeholders #416

Open
ItsMicah001 opened this issue Apr 14, 2020 · 3 comments
Open

[Feature] QuickShop PAPI Placeholders #416

ItsMicah001 opened this issue Apr 14, 2020 · 3 comments
Assignees
Labels
Enhancement New feature or request Good First Issue Good for newcomers Priority:Major Major Should Implement By Addon This request should implement by create addon, not add in the quickshop core.

Comments

@ItsMicah001
Copy link

Describe the Feature
Add placeholders relating to QuickShop that can be used by other plugins through Placeholder API (PAPI).

  • %quickshop_customer_sales_value% -Displays the dollar amount of a player's sales made through quickshop. (Selling to another person's shop)
  • %quickshop_customer_sales% -Displays how many sales a player has made through quickshop. (Selling to another person's shop)
  • %quickshop_sales_value% -Displays the dollar amount of a player's sales made through quickshop. (Sold from their own shop)
  • %quickshop_sales% -Displays how many sales a player has made through quickshop. (Sold from their own shop)
  • %quickshop_customer_purchased_value% -Displays the dollar amount of a player's purchases made through quickshop. (Buying from another person's shop)
  • %quickshop_customer_purchases% -Displays how many purchases a player has made through quickshop. (Buying from another person's shop)
  • %quickshop_purchased_value% -Displays the dollar amount of a player's purchases made through quickshop. (Buying with their own shop)
  • %quickshop_purchases% -Displays how many purchases a player has made through quickshop. (Buying with their own shop)
  • %quickshop_customer_networth% -Displays the net dollar amount of a player's transactions. (Buying and selling to other people's shops)
  • %quickshop_networth% -Displays the net dollar amount of a player's transactions. (Buying and selling with their own shops)
  • %quickshop_customer_total% -Displays how many transactions a player has made through quickshop. (Through other's shops)
  • %quickshop_total% -Displays how many transactions a player has made through quickshop. (Through their own shops)

Screenshots
I cannot think of any applicable screenshots.

Additional context
These placeholders are what I could come up with, however if there are additional placeholders that you may find useful then there may be more to add. PS I am not very good at coming up with names, I hope that the descriptions explain what these placeholders would display.

@sandtechnology sandtechnology added Enhancement New feature or request Good First Issue Good for newcomers Should Implement By Addon This request should implement by create addon, not add in the quickshop core. labels Apr 15, 2020
@RustyDagger
Copy link

if all the data needed to get those numbers was available a PAPI extension would not doubt suffice. If its not then i'm not sure if the extension could track/store all that data.
I do like the idea however and its something I would use.

@Ghost-chu Ghost-chu added Priority:Minor Minor and removed Should Implement By Addon This request should implement by create addon, not add in the quickshop core. labels Apr 15, 2020
@Ghost-chu
Copy link
Owner

Pull into TODO list.
Some interface actually will kind of damage performance, i'm pretty sure it won't contains in next version.
BUT, it will in quickshop, this idea is cool and useful, but we need think about how to caching data and how many data need to show.

@sandtechnology
Copy link
Collaborator

Pull into TODO list.
Some interface actually will kind of damage performance, i'm pretty sure it won't contains in next version.
BUT, it will in quickshop, this idea is cool and useful, but we need think about how to caching data and how many data need to show.

I think create a github project for all the feature request will be useful for recording todo list, and the implement actually mainly is about data storage and how the data show, just create a new table to store and a new data handler class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request Good First Issue Good for newcomers Priority:Major Major Should Implement By Addon This request should implement by create addon, not add in the quickshop core.
Projects
None yet
Development

No branches or pull requests

4 participants