Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reactions users view not paginating results #712

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Fix reactions users view not paginating results #712

merged 3 commits into from
Jan 13, 2025

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jan 10, 2025 •
edited
Loading

🔗 Issue Link

Resolves IOS-590

🎯 Goal

Fix reactions users view not paginating results.

🧪 Testing

  1. Open a message with more than 20+ reactions.
  2. It should load all reactions.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@nuno-vieira nuno-vieira requested a review from a team as a code owner January 10, 2025 17:38
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 10, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.54 MB 7.54 MB +1 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
61.5% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@nuno-vieira nuno-vieira merged commit f566ec1 into develop Jan 13, 2025
11 of 12 checks passed
@nuno-vieira nuno-vieira deleted the fix/message-reactions-not-paginating branch January 13, 2025 16:50
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @Stream-SDK-Bot @martinmitrevski