Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor how filters are handled #3

Open
mcannon068nw opened this issue Feb 1, 2024 · 2 comments
Open

refactor how filters are handled #3

mcannon068nw opened this issue Feb 1, 2024 · 2 comments
Labels
bug Something isn't working priority:medium Medium priority

Comments

@mcannon068nw
Copy link
Contributor

I'm not sure filters are currently working anymore. Additionally there is some ambiguity on proper way to implement this. May want to revisit how the query string is built as a related issue.

@jsstevenson jsstevenson self-assigned this Apr 3, 2024
@jsstevenson jsstevenson added bug Something isn't working priority:medium Medium priority labels Apr 3, 2024
@jsstevenson
Copy link
Member

jsstevenson commented Apr 5, 2024

#29 cleans up some of the queries/params, but I do think that some (not all) of the filters have a separate problem (copied from another issue)

I think the problem is with our resolvers, not with the queries or anything we're doing here, but I believe that filters like sourceDbName on interactions are fetching all interactions for genes that have an interaction provided by that source -- rather than fetching just those interactions provided by that source. Ditto pmid and interactionTypes.

I would lean towards removing them for now for this reason -- because they aren't super helpful like this.

@jsstevenson jsstevenson removed their assignment Apr 13, 2024
@jsstevenson
Copy link
Member

Depends on dgidb/dgidb-v5#490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants