Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2.13] Navigating in the server file selector and opening directories #986

Open
1 of 2 tasks
LisaAlmarode opened this issue Dec 14, 2022 · 2 comments
Open
1 of 2 tasks
Assignees

Comments

@LisaAlmarode
Copy link
Member

LisaAlmarode commented Dec 14, 2022

  • When I double click on a directory in the file selector to open it, after it opens that directory, it always shows a highlight on the file at the same offset. E.g., Plantis-Tests is the second directory in src, so the second file shows highlighting.

image

While this LOOKS like a file is selected, it's not actually selected Pressing the select button results opens the directory.

  • You should not be able to "open" a directory as if it was an empty file. If a directory is selected, the select button should either do nothing, or otherwise open the directory within the file selector so you can further navigate/select from the contents of that directory.

image

ericwinger pushed a commit that referenced this issue Dec 16, 2022
[3.2.13] Navigating in the server file selector and opening directories #986

Put up a message if an attempt is made to press select on a directory.
ericwinger added a commit to GemTalk/RowanClientServices that referenced this issue Dec 16, 2022
As part of work for GemTalk/Jadeite#986
Add new isDirectory command
@ericwinger
Copy link
Member

@LisaAlmarode When I double click on a directory in the file selector to open it, after it opens that directory, it always shows a highlight on the file at the same offset. E.g., Plantis-Tests is the second directory in src, so the second file shows highlighting.
The highlighting problem (for me) just seems to be the cursor sitting on the same position after the window updates. That doesn't seem wrong. Notice the two different shades of blue in the example. As I move the cursor around after the double-click & window contents update, the highlight moves with me.

@LisaAlmarode
Copy link
Member Author

This is still a problem. I don't know what example Eric is referring to, but on my system there is just a single shade of dark blue, and very misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants