Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystem Errors should subclass FsError #123

Open
kurtkilpela opened this issue Feb 28, 2023 · 3 comments
Open

FileSystem Errors should subclass FsError #123

kurtkilpela opened this issue Feb 28, 2023 · 3 comments
Assignees
@kurtkilpela

Comments

@kurtkilpela
Copy link
Member

Right now, all FileSystem errors subclass Error. Instead, we should have them subclass a new class called FsError.

FsUnixError should remain in a separate hierarchy.
@kurtkilpela kurtkilpela self-assigned this Feb 28, 2023
@kurtkilpela
Copy link
Member Author

Fixed in 3ef2cc2

@LisaAlmarode
Copy link
Member

I think FsFileDescriptorInvalid should be under FsError too...

@LisaAlmarode LisaAlmarode reopened this Mar 6, 2023
@kurtkilpela
Copy link
Member Author

Yeah it should be. It also needs an error number associated with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kurtkilpela kurtkilpela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kurtkilpela @LisaAlmarode