Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license texts #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

michel-slm
Copy link

Fixes #13

sptr on  add-license [+]
❯ cargo package --allow-dirty --no-verify
   Packaging sptr v0.3.2 (/home/michel/src/github/Gankra/sptr)

sptr on  add-license [+]
❯ tar tf target/package/sptr-0.3.2.crate
sptr-0.3.2/.github/workflows/rust.yml
sptr-0.3.2/.gitignore
sptr-0.3.2/Cargo.toml
sptr-0.3.2/Cargo.toml.orig
sptr-0.3.2/LICENSE-APACHE
sptr-0.3.2/LICENSE-MIT
sptr-0.3.2/README.md
sptr-0.3.2/src/func.rs
sptr-0.3.2/src/int.rs
sptr-0.3.2/src/lib.rs

Signed-off-by: Michel Alexandre Salim [email protected]

Fixes Gankra#13

```
sptr on  add-license [+]
❯ cargo package --allow-dirty --no-verify
   Packaging sptr v0.3.2 (/home/michel/src/github/Gankra/sptr)

sptr on  add-license [+]
❯ tar tf target/package/sptr-0.3.2.crate
sptr-0.3.2/.github/workflows/rust.yml
sptr-0.3.2/.gitignore
sptr-0.3.2/Cargo.toml
sptr-0.3.2/Cargo.toml.orig
sptr-0.3.2/LICENSE-APACHE
sptr-0.3.2/LICENSE-MIT
sptr-0.3.2/README.md
sptr-0.3.2/src/func.rs
sptr-0.3.2/src/int.rs
sptr-0.3.2/src/lib.rs
```

Signed-off-by: Michel Alexandre Salim <[email protected]>
jrvanwhy added a commit to jrvanwhy/libtock-rs that referenced this pull request Aug 22, 2023
The semantics of int-to-pointer casts under strict provenance has changed. Ideally, we would update our `From<usize> for Register` implementation to use the `sptr` crate, but `sptr` does not currently have a suitable license. There is a [PR](Gankra/sptr#14) to change that, but it hasn't gotten a response in 7 months, so I don't think we can use it. Instead, this copies the implementation of `core::ptr::invalid`.

This also bumps our `thiserror` dependency, which forces Cargo to pick a newer version of `proc-macro2` that is compatible with recently nightly toolchains.
jrvanwhy added a commit to jrvanwhy/libtock-rs that referenced this pull request Aug 22, 2023
The semantics of int-to-pointer casts under strict provenance has changed. Ideally, we would update our `From<usize> for Register` implementation to use the `sptr` crate, but `sptr` does not currently have a suitable license. There is a [PR](Gankra/sptr#14) to change that, but it hasn't gotten a response in 7 months, so I don't think we can use it. Instead, this copies the implementation of `core::ptr::invalid`.

This also bumps our `thiserror` dependency, which forces Cargo to pick a newer version of `proc-macro2` that is compatible with recently nightly toolchains.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please ship license texts
1 participant