Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties only working on particular Z3 versions #166

Open
2 of 6 tasks
mccleeary-galois opened this issue Oct 31, 2024 · 1 comment
Open
2 of 6 tasks

Properties only working on particular Z3 versions #166

mccleeary-galois opened this issue Oct 31, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mccleeary-galois
Copy link
Contributor

mccleeary-galois commented Oct 31, 2024

Summary

Currently some properties only work with the latest version of Z3 not what is shipped with what4-solvers

https://github.com/GaloisInc/what4-solvers/releases/tag/snapshot-20240212

This was found during review of #161

Acceptance Criteria

Properties that do not :prove on Z3 4.8.14 have been identified and documented and changed to :check in the docstrings

Do

  • define acceptance criteria
  • add appropriate labels
  • remember to update CHANGES
  • remember to update docs appropriately
  • identified properties that do not :prove on Z3 4.8.14
  • Documented and updated properties to use :check with explanation that it is provable with more recent versions of Z3.
@marsella
Copy link
Contributor

marsella commented Nov 1, 2024

On master (at commit 774ec5b), using z3 4.8.14, I found that

  • SHA3 Tests finish
  • ML-KEM 512 KAT finishes
  • ML-KEM 512 internal docstrings finish

On 144-compress

  • Fast: roundingWorks; compressInvertsDecompress`{1, d_v}
  • More than 30s : compressInvertsDecompress`{d_u}, decompressMostlyInvertsCompress -- these both work with exhaust instead.

On 144-encode

  • All new properties finish within 30s

On 147-ntt

  • :check-docstrings finishes. It's not particularly fast but it finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants