Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gff3ToAnnotationFeature for adding feature from evidence track #504

Open
garrettjstevens opened this issue Jan 8, 2025 · 0 comments
Open

Use gff3ToAnnotationFeature for adding feature from evidence track #504

garrettjstevens opened this issue Jan 8, 2025 · 0 comments
Assignees
@dariober

Comments

@garrettjstevens
Copy link
Contributor

The logic in packages/jbrowse-plugin-apollo/src/extensions/annotationFromJBrowseFeature.ts is similar to that of packages/apollo-shared/src/GFF3/gff3ToAnnotationFeature.ts, so we should probably rework it to use gff3ToAnnotationFeature (especially since gff3ToAnnotationFeature has unit tests).

So basically we'd have a function that converts a JBrowse SimpleFeature to a GFF3Feature, and then call gff3ToAnnotationFeature on that.
dariober added a commit that referenced this issue Jan 14, 2025
@dariober
Address issue #504
aa50849 
Some imporvements probably needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dariober dariober

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dariober @garrettjstevens