Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark truncated earlier #118

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Mark truncated earlier #118

merged 1 commit into from
Oct 23, 2024

Conversation

sidnarayanan
Copy link
Collaborator

Fixes #117

Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to unit test this, as it's definitely a "gotcha" our test suite should catch

@sidnarayanan
Copy link
Collaborator Author

@jamesbraza going to merge this in so we have the fix, but I'll keep #117 open to remind myself to add a test

@sidnarayanan sidnarayanan merged commit 571ac6e into main Oct 23, 2024
6 checks passed
@sidnarayanan sidnarayanan deleted the trunc-fix branch October 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set truncated flag before callback invocation
3 participants