Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update forc-crypto plugin #5170

Closed
cr-fuel opened this issue Oct 4, 2023 · 1 comment
Closed

Update forc-crypto plugin #5170

cr-fuel opened this issue Oct 4, 2023 · 1 comment
Assignees
@cr-fuel
Labels
enhancement New feature or request forc P: low

Comments

@cr-fuel
Copy link
Contributor

cr-fuel commented Oct 4, 2023

In #5153 forc-crypto was introduced and it has its own copy of keygen from fuel-core. In FuelLabs/fuel-core#1397 keygen has been updated to stop depending in protoc and it has a crate.

Update forc-crypto in the next fuel-core-keygen release to reference it instead of copying it.
@cr-fuel cr-fuel added enhancement New feature or request forc P: low labels Oct 4, 2023
@cr-fuel cr-fuel self-assigned this Oct 4, 2023
@JoshuaBatty JoshuaBatty mentioned this issue Oct 12, 2023
Merged
13 tasks
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 17, 2023
@cr-fuel
Split keygen into a create and a binary
95279d6 
Split so it can be inherited from other binaries FuelLabs/sway#5170
@cr-fuel cr-fuel mentioned this issue Oct 17, 2023
Merged
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 17, 2023
@cr-fuel
Split keygen into a create and a binary
ccd3d54 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 17, 2023
@cr-fuel
Split keygen into a create and a binary
b628175 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 17, 2023
@cr-fuel
Split keygen into a create and a binary
40416bb 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 18, 2023
@cr-fuel
Split keygen into a create and a binary
9e0af00 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 18, 2023
@cr-fuel
Split keygen into a create and a binary
6d2d43f 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 18, 2023
@cr-fuel
Split keygen into a create and a binary
438004b 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 19, 2023
@cr-fuel
Split keygen into a create and a binary
2acc9d7 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 23, 2023
@cr-fuel
Split keygen into a create and a binary
5405584 
Split so it can be inherited from other binaries FuelLabs/sway#5170
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Oct 23, 2023
@cr-fuel
Split keygen into a create and a binary (#1426)
bbd0992 
Split so it can be inherited from other binaries
FuelLabs/sway#5170
@cr-fuel cr-fuel mentioned this issue Oct 31, 2023
Merged
cr-fuel added a commit to FuelLabs/fuel-core that referenced this issue Nov 1, 2023
@cr-fuel
Improvements for keygen cli and crates (#1465)
8a323ad 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy
(FuelLabs/sway#5170)
@cr-fuel
Copy link
Contributor Author

cr-fuel commented Nov 17, 2023

This is done in #5273 and will be released once #4820 gets merged.

@cr-fuel cr-fuel closed this as completed Dec 1, 2023
crypto523 added a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
@crypto523
Split keygen into a create and a binary (#1426)
935a5d8 
Split so it can be inherited from other binaries
FuelLabs/sway#5170
crypto523 added a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
@crypto523
Improvements for keygen cli and crates (#1465)
691a7ea 
Import improvements from FuelLabs/sway#5153.

Once this PR is merged and a new release is created sway will reference
this crate instead of having its own copy
(FuelLabs/sway#5170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cr-fuel cr-fuel

Labels
enhancement New feature or request forc P: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cr-fuel