Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reentrancy guard #102

Open
adlerjohn opened this issue Oct 31, 2022 · 1 comment
Open

Rename reentrancy guard #102

adlerjohn opened this issue Oct 31, 2022 · 1 comment

Comments

@adlerjohn
Copy link
Contributor

adlerjohn commented Oct 31, 2022

Either rename or better document the reentrancy guard. The guard only protects against control flow hijacking on a single contract, not multiple trusted contracts working together. While the latter case may be less common on Fuel due to a larger contract size limit, it will still happen.

See more: https://inspexco.medium.com/cross-contract-reentrancy-attack-402d27a02a15

The guard should also be documented to not be needed if CEI is followed, which is enforced by the compiler.

@nfurfaro nfurfaro self-assigned this Jan 25, 2023
@mohammadfawaz mohammadfawaz transferred this issue from FuelLabs/sway Feb 20, 2023
@mohammadfawaz mohammadfawaz changed the title Rename stdlib reentrancy guard Rename reentrancy guard Feb 20, 2023
@mohammadfawaz
Copy link

cc @jtriley-eth - I transferred this issue from the Sway repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants