Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuel wallet does not have a delete button #1283

Open
BlackEyesForThree opened this issue May 10, 2024 · 5 comments · May be fixed by #1377
Open

Fuel wallet does not have a delete button #1283

BlackEyesForThree opened this issue May 10, 2024 · 5 comments · May be fixed by #1377

Comments

@BlackEyesForThree
Copy link

Motivation

When a user needs to delete one of the sub account addresses, can this feature be added without a convenient delete button?
微信图片_20240510134613

Usage example

No response

Possible implementations

No response

@ameeetgaikwad
Copy link

Would like to help!

@BlackEyesForThree
Copy link
Author

Thank you very much, so we can start adding the delete button. Used to delete excess addresses from wallet users and add secondary confirmation.

@ameeetgaikwad ameeetgaikwad linked a pull request Jun 13, 2024 that will close this issue
@ameeetgaikwad
Copy link

ameeetgaikwad commented Jun 17, 2024

@BlackEyesForThree should i hide it when asked to delete?

Or should i remove the account from the accounts array from useAccounts ?

@luizstacio
Copy link
Member

@ameeetgaikwad It depends on the action;
Deletion is only possible if the account is imported from a private account.
For seed phrases, delete does not exist as accounts are just indexes, and this is why we use the wording hide account.

I think the button should be conditional; if it is from a seed phrase, we show hidden accounts.
It it is from privateKey, show delete account.

@ameeetgaikwad
Copy link

@ameeetgaikwad It depends on the action; Deletion is only possible if the account is imported from a private account. For seed phrases, delete does not exist as accounts are just indexes, and this is why we use the wording hide account.

I think the button should be conditional; if it is from a seed phrase, we show hidden accounts. It it is from privateKey, show delete account.

got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants