Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate snippets from fuel-gauge #1505

Open
Tracked by #2503
danielbate opened this issue Dec 11, 2023 · 4 comments · May be fixed by #3397
Open
Tracked by #2503

Migrate snippets from fuel-gauge #1505

danielbate opened this issue Dec 11, 2023 · 4 comments · May be fixed by #3397
Labels
docs Requests pertinent to documentation

Comments

@danielbate
Copy link
Contributor

We currently have quite a few tests that references documentation from fuel-gauge. These scenarios are at times improperly formed in order to be more verbose and illustrate techniques rather than validate the end to end functionality of the SDK. As that is the intended usage of fuel-gauge, we should instead move fuel-gauge/src/doc-examples.test.ts to appropriate places in apps/docs-snippets. The documentation references will also need to be altered as the links will have been broken.
@danielbate danielbate added the docs Requests pertinent to documentation label Dec 11, 2023
@danielbate danielbate mentioned this issue Dec 11, 2023
Merged
@arboleya arboleya changed the title Move fuel-gauge/src/doc-examples.test.ts -> apps/docs-snippets Migrate all code-snippets from fuel-gauge to docs-snippets Dec 12, 2023
@petertonysmith94
Copy link
Contributor

@danielbate pls

@danielbate
Copy link
Contributor Author

Sorry meant to assign you @petertonysmith94

@petertonysmith94
Copy link
Contributor

Notes:

  • vector-4
    Doesn't show a return value in the documentation // expect value would be beneficial.

This was referenced Jan 20, 2024
Closed
Closed
@petertonysmith94 petertonysmith94 mentioned this issue Mar 18, 2024
Merged
@petertonysmith94 petertonysmith94 removed their assignment Apr 12, 2024
@petertonysmith94
Copy link
Contributor

Unassigned the issue, moved the wallet code snippets and left the PR in draft. Might be helpful as part of #1919.

May be worth consideration while the docs revamp is in progress #1924

@arboleya arboleya removed the mainnet label Apr 13, 2024
@petertonysmith94 petertonysmith94 mentioned this issue Apr 15, 2024
Merged
@arboleya arboleya added the p1 label Jun 9, 2024
@arboleya arboleya added this to the 0.x post-launch milestone Jun 12, 2024
@arboleya arboleya added p2 and removed p1 labels Jun 12, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya removed the p2 label Jul 20, 2024
@arboleya arboleya added the temp:notion label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
@arboleya arboleya mentioned this issue Sep 8, 2024
Closed
16 tasks
@maschad maschad self-assigned this Oct 3, 2024
@maschad maschad removed their assignment Oct 23, 2024
@arboleya arboleya changed the title Migrate all code-snippets from fuel-gauge to docs-snippets Migrate snippets from fuel-gauge to docs-snippets Oct 23, 2024
@arboleya arboleya changed the title Migrate snippets from fuel-gauge to docs-snippets Migrate snippets from fuel-gauge Oct 23, 2024
@Dhaiwat10 Dhaiwat10 mentioned this issue Nov 13, 2024
Closed
4 tasks
@petertonysmith94 petertonysmith94 linked a pull request Nov 15, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
No milestone
4 participants
@arboleya @danielbate @maschad @petertonysmith94