refactor: move type:check to lint hook #3381
Open
+10
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed type:check from pretest, build, and postbuild scripts - Added type checking to lint command - Improves development speed by reducing redundant type checks Fixes FuelLabs#3248
Rohit-Bhetal
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
|
@Rohit-Bhetal is attempting to deploy a commit to the Fuel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
…st, build, and postbuild scripts- Added type checking to lint command- Improves development speed by reducing redundant type checksFixes FuelLabs#3248
Rohit-Bhetal
commented
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3248
Release notes
So the issue with slower development cycle is solved by using eslint for type check:
Description
This PR moves the TypeScript type checking from the various build-related scripts (pretest, postbuild, etc.) to a dedicated
lintscript. This helps improve the development speed by reducing the number of redundant type checks performed during the build process.Changes
type:checkcommand from thepretest,build, andpostbuildscripts in the variouspackage.jsonfiles.lintscript that runstsc --noEmitto perform the TypeScript type checking.package.jsonfiles to use the newlintscript instead of the previoustype:checkcommands.Benefits
lintscript.Breaking Changes
No significant risks are identified. The changes are limited to the package.json files and do not introduce any new functionality or change the core logic of the project.
Checklist