Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes on adding non-Rust packages to fuel.nix in the future #63

Open
mitchmindtree opened this issue May 30, 2023 · 0 comments
Open

Notes on adding non-Rust packages to fuel.nix in the future #63

mitchmindtree opened this issue May 30, 2023 · 0 comments

Comments

@mitchmindtree
Copy link
Contributor

The mkPackages function and patches.nix both make some assumptions based on the expectation that packages being built are Rust packages. This is fine for all fuel-core, sway and indexer packages, however these assumptions may need to be revisited if we aim to build non-Rust packages (e.g. NPM-based TS/JS stuff) in the future.

In order to enable building non-Rust packages, we should separate manifests by build process (e.g. buildRustPackage, buildNpmPackage, etc), either at the time of manifest creation, or by filtering them after their loaded using lists of names (e.g. one list of Rust package names, another list of NPM package names, etc).

E.g. the first condition under patches.nix should be revisited to ensure it is only applied for Rust-package manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant