Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to dodge flakiness in heavy_tasks_doesnt_block_graphql test #2437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Attempt to dodge flakiness in heavy_tasks_doesnt_block_graphql test #2437

wants to merge 1 commit into from

Conversation

rafal-ch
Copy link
Contributor

@rafal-ch rafal-ch commented Nov 14, 2024 •
edited
Loading

Closes #2435

Description

This is an attempt to resolve observed flakiness in the heavy_tasks_doesnt_block_graphql test.

When I tested the fix locally, with much smaller (250ms) timeouts and debug prints, I could observe the following outcome:

running 1 test
ERR
ERR
OK
test dos::heavy_tasks_doesnt_block_graphql ... ok

Changes:

  1. Allow retrying the "health" check request 3 times
  2. Because we now allow 3 tries instead of just 1
    3. Reduce timeout from 5 to 4 seconds
    4. Spam the node with 3 times as much requests in the background (50 -> 150).

This is an effort to make the test more resilient to the performance of the machine it is executed on.

Before requesting review

  • I have reviewed the code myself

@rafal-ch rafal-ch added the no changelog Skip the CI check of the changelog modification label Nov 14, 2024
@rafal-ch rafal-ch requested a review from a team November 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaxy test: heavy_tasks_doesnt_block_graphql
1 participant
@rafal-ch