New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Nonce of messages received by relayer #1834

Open

MitchTurner opened this issue Apr 17, 2024 · 1 comment · May be fixed by #2375

Assignees

Member

MitchTurner commented Apr 17, 2024

Our code assumes that each message received by the relayer has a unique nonce, but doesn't check that this is true.

A collision could be very bad because it would override the previous message.

For now, maybe we halt the relayer if this occurs? We could also handle specific cases, like if the old message has already been spent?

Member

Voxelot commented Jul 18, 2024

we should probably just skip nonces that have already been seen before

MitchTurner self-assigned this

MitchTurner linked a pull request

that will close this issue

Ignore messages with duplicated nonces #2375

Draft

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment