-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The plug-in hides an entry after decline a patch candidate #94
Labels
Comments
searchlab-team
added a commit
to searchlab-team/AIFix4SecCode
that referenced
this issue
Jul 4, 2022
- FrontEndART#94: Fixed bug where declining a warning patch candidate would result the removal of the entire warning from the analysis output window. - FrontEndART#73: Changed format of generated config.property file.
chicxurug
pushed a commit
that referenced
this issue
Jul 25, 2022
* Applied new 'grouped' json config layout to vscode-plugin. #59 * Update issues TreeView to show the number of subelements. * vscode-plugin issues bugfix (1.0.11) #60 #73 #78 #79 #80 * Bugfix for #90. -Selection and cursor are now set to the warning's position whenever an issue is opened up in the editor. * vscode-plugin bugfix for #73. -The config.properties file are now generated into the folder set up as the "Executable Path". * Update version of vscode-plugin. * Vscode-Plugin update 1.0.13. - #94: Fixed bug where declining a warning patch candidate would result the removal of the entire warning from the analysis output window. - #73: Changed format of generated config.property file.
chicxurug
pushed a commit
that referenced
this issue
May 9, 2023
…s. (#106) * Applied new 'grouped' json config layout to vscode-plugin. #59 * Update issues TreeView to show the number of subelements. * vscode-plugin issues bugfix (1.0.11) #60 #73 #78 #79 #80 * Bugfix for #90. -Selection and cursor are now set to the warning's position whenever an issue is opened up in the editor. * vscode-plugin bugfix for #73. -The config.properties file are now generated into the folder set up as the "Executable Path". * Update version of vscode-plugin. * Vscode-Plugin update 1.0.13. - #94: Fixed bug where declining a warning patch candidate would result the removal of the entire warning from the analysis output window. - #73: Changed format of generated config.property file. * Update patch.ts to fix refreshing the list of the detected vulnerabilities issue. - Referenced issue: #105 * Update plugin version. * Remove unnecessary settings from plugin config. Reducing the users' responsibility #109 * Update README.md * Update plugin README.md * Started reworking analysis call to only run on current cu. * Minor fixes for windows with using OpenStaticAnalyzer. * Minor fix for multiple analysis failure in plugin. * Update plugin with new analyzer executable as parameter -Reworked treeview generation with merging multiple json input as one json. * Update saving previous state after patching in case of redo. * Update status bar to support analysis on currently opened file. * Starting multiple simultaneous analysis are no longer possible when status bar command is pressed repeatedly. * Create custom output channel for the extensions logging. * Remove old issue config updates. * Minor fixes with patch view mode. * Update treeview builder. * Analysis output treeView build bugfix. -Incorrect number of issues would show up in the treeview after analysis. * Simplified configuration handling. - use of -config flag is no longer needed in executableParameters, the plugin now uses it automatically. - Only one config file are used for both the executable and the plugin. * Update analyzer logic with new config handling and treeview refresh. * Fixed Testview command already exists unhandled errors issue. * Revert "Fixed Testview command already exists unhandled errors issue." This reverts commit f3756e8. * (Re) Fixed Testview command already exists unhandled errors issue. * After manual save of a file, a file analysis now starts to refresh the results. * Fixed unhandled 'webview is disposed' error. * Analysis no longer runs on unsupported documents. * Fix bug where code actions no longer appeared at other files but the file that was lastly analyzed. * Analysis will no longer be started after declining a patch. * Fixed some treeview refreshing issues after editing and analyzing a file. * Add new try-catch scopes for previously unhandled errors. * update treeView refresh after applying or declining patches. * fixed bug at issue tree where after a patch was applied the issue tree had many duplicate issues pointing to the same location. * Sorting patches by score. * sorter wrapper * add sorter --------- Co-authored-by: Ákos <[email protected]> Co-authored-by: Péter Mészáros <[email protected]>
chicxurug
pushed a commit
that referenced
this issue
May 23, 2023
* Applied new 'grouped' json config layout to vscode-plugin. #59 * Update issues TreeView to show the number of subelements. * vscode-plugin issues bugfix (1.0.11) #60 #73 #78 #79 #80 * Bugfix for #90. -Selection and cursor are now set to the warning's position whenever an issue is opened up in the editor. * vscode-plugin bugfix for #73. -The config.properties file are now generated into the folder set up as the "Executable Path". * Update version of vscode-plugin. * Vscode-Plugin update 1.0.13. - #94: Fixed bug where declining a warning patch candidate would result the removal of the entire warning from the analysis output window. - #73: Changed format of generated config.property file. * Update patch.ts to fix refreshing the list of the detected vulnerabilities issue. - Referenced issue: #105 * Update plugin version. * Remove unnecessary settings from plugin config. Reducing the users' responsibility #109 * Update README.md * Update plugin README.md * Started reworking analysis call to only run on current cu. * Minor fixes for windows with using OpenStaticAnalyzer. * Minor fix for multiple analysis failure in plugin. * Update plugin with new analyzer executable as parameter -Reworked treeview generation with merging multiple json input as one json. * Update saving previous state after patching in case of redo. * Update status bar to support analysis on currently opened file. * Starting multiple simultaneous analysis are no longer possible when status bar command is pressed repeatedly. * Create custom output channel for the extensions logging. * Remove old issue config updates. * Minor fixes with patch view mode. * Update treeview builder. * Analysis output treeView build bugfix. -Incorrect number of issues would show up in the treeview after analysis. * Simplified configuration handling. - use of -config flag is no longer needed in executableParameters, the plugin now uses it automatically. - Only one config file are used for both the executable and the plugin. * Update analyzer logic with new config handling and treeview refresh. * Fixed Testview command already exists unhandled errors issue. * Revert "Fixed Testview command already exists unhandled errors issue." This reverts commit f3756e8. * (Re) Fixed Testview command already exists unhandled errors issue. * After manual save of a file, a file analysis now starts to refresh the results. * Fixed unhandled 'webview is disposed' error. * Analysis no longer runs on unsupported documents. * Fix bug where code actions no longer appeared at other files but the file that was lastly analyzed. * Analysis will no longer be started after declining a patch. * Fixed some treeview refreshing issues after editing and analyzing a file. * Add new try-catch scopes for previously unhandled errors. * update treeView refresh after applying or declining patches. * fixed bug at issue tree where after a patch was applied the issue tree had many duplicate issues pointing to the same location. * Sorting patches by score. * sorter wrapper * add sorter * vscode-plugin fixes --------- Co-authored-by: Ákos <[email protected]> Co-authored-by: Péter Mészáros <[email protected]> Co-authored-by: LDavid7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If there are several fix candidates for a warning instance and we decline one of them, the plug-in removes the warning from the analysis output window. This is incorrect behavior, it should only remove the warning of the last candidate is declined. Otherwise, it should discard the patch candidate only and keep the warning with the remaining fix candidates.
The text was updated successfully, but these errors were encountered: