Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[distribution] tracker for debian package #3

Open
xhub opened this issue Dec 21, 2016 · 3 comments
Open

[distribution] tracker for debian package #3

xhub opened this issue Dec 21, 2016 · 3 comments

Comments

@xhub
Copy link
Member

xhub commented Dec 21, 2016

This is mostly a tracker for myself

  • we should install a fclib.so.1.0 so that there is a versioning
  • we should not install csparse.h, we do not need it and it may collide with the cparse from siconos
  • check lintian report
@radarsat1
Copy link
Contributor

I am looking into making an fclib package along with Siconos. Can you help me understand the current state of things with fclib?

I am confused because the latest release is tagged as v2.0.0 but this is not merged with master, but rather is a branch and coincides with the tag 1.0.0. Currently that v2.0.0 does for me with:

fatal error: csparse.h: No such file or directory

(It seems it does not find it in externals.) On the other hand the master branch does build. I would say that what is needed is to add SONAME (ABI tracking) as you mention here, and do a release. I don't see any issues blocking for this.

I would suggest making SONAME start at 0, for release 3.0.0, (or 2.1.0, whatever) and only increase it when the C API/ABI changes. This can be done in CMake by providing SOVERSION along with VERSION when calling set_target_properties.

I would do it myself and propose a release but I am confused by the branching with the v2.0.0/1.0.0 tags.

@vacary
Copy link
Contributor

vacary commented Mar 15, 2018

It is a little confusing. The tag 1.0.0 is an error of mine. I created this tag when I wanted to create the v2.0.0 version. Now it is impossible to remove it. It is curious that is not able to find csparse.h. Perhaps, we have tested without a csparse.h installed in the system.

You can create the v3.0.0 with the master.

@radarsat1
Copy link
Contributor

Ok. Btw you can remove the tag, you just delete it locally "git tag -d ..." and then push it with a colon prepended to the tag name, like,

git push origin :1.0.0

I have done it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants