Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use dynamic object properties #53

Open
andrewbelcher opened this issue Jun 16, 2017 · 1 comment
Open

Don't use dynamic object properties #53

andrewbelcher opened this issue Jun 16, 2017 · 1 comment

Comments

@andrewbelcher
Copy link
Collaborator

ContactsTabManager::verifyTab uses $block->_contactTabVerified, a dynamically set property on the blocks. This breaks property optimisation (see https://www.drupal.org/node/2531564) and so we shouldn't do it.

It's possible there are other places we've done this...

@andrewbelcher
Copy link
Collaborator Author

This use case would be better solved by a defined property on the tab, something like $verifiedBlocks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant