Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfecta fails to process all schemes #302

Open
gplindstrom opened this issue Aug 8, 2017 · 0 comments
Open

Superfecta fails to process all schemes #302

gplindstrom opened this issue Aug 8, 2017 · 0 comments

Comments

@gplindstrom
Copy link

gplindstrom commented Aug 8, 2017

Using Sangoma Linux release 7.3.1701 (Core) with PHP version 5.6.31 and Freepbx. At least for me, only the first scheme is executed (when ALL is specified) and sets the callerid to blank/null if not found with the lookups in that scheme. Problem appears to be in Superfecta.class.php. When I change the line:
$callerid = $spam_text . " " . $superfecta->get_Prefix() . $callerid;

to:
$callerid = trim($spam_text . " " . $superfecta->get_Prefix() . $callerid);

all seems to work again. For good measure, I also changed the line
$callerid = $spam_text;

to:
$callerid = trim($spam_text);

just in case blanks or something similar are returned in spam_text. This may be an issue (or not) with how older/newer versions of php processed empty. Or maybe it is just a bug.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant